Comments on: gba2wsc Released http://liranuna.drunkencoders.com/gba2wsc-released/ Just another console developper Fri, 04 Jul 2008 19:12:25 +0000 http://wordpress.org/?v=2.1.1 By: Peter http://liranuna.drunkencoders.com/gba2wsc-released/#comment-2331 Peter Sat, 23 Dec 2006 16:02:00 +0000 http://liranuna.drunkencoders.com/gba2wsc-released/#comment-2331 Hi, just took a quick look at the code from gba2wsc. It looks like you don't free the allocated memory on the heap. Noticed that in fixMap() and fixPalette(). I would also open the input files in "rb" mode, rather than just "r". I remember in one of my applications I also used "r" to read binary files and it sometimes didn't work properly. Best, Peter Hi, just took a quick look at the code from gba2wsc. It looks like you don’t free the allocated memory on the heap. Noticed that in fixMap() and fixPalette().

I would also open the input files in “rb” mode, rather than just “r”. I remember in one of my applications I also used “r” to read binary files and it sometimes didn’t work properly.

Best,
Peter

]]> By: Strager Neds http://liranuna.drunkencoders.com/gba2wsc-released/#comment-2356 Strager Neds Tue, 26 Dec 2006 15:46:35 +0000 http://liranuna.drunkencoders.com/gba2wsc-released/#comment-2356 Peter, Having "b" in the second parameter of fopen tells DOS (and perhaps other systems) not to process newlines and other command characters at all. Linux does not fiddle with such things, thus it is not required. Since LiraNuna tests on a Linux system, he probably forgot to add this flag for compatibility. Just thought you might want to know why you should add the binary flag in your fopen statements. (BTW, LiraNuna, check your e-mail...!) Peter,
Having “b” in the second parameter of fopen tells DOS (and perhaps other systems) not to process newlines and other command characters at all. Linux does not fiddle with such things, thus it is not required. Since LiraNuna tests on a Linux system, he probably forgot to add this flag for compatibility.

Just thought you might want to know why you should add the binary flag in your fopen statements.

(BTW, LiraNuna, check your e-mail…!)

]]>